Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken link adr-008-app-caller-cbs.md #7736

Closed
wants to merge 3 commits into from

Conversation

duvbell
Copy link
Contributor

@duvbell duvbell commented Dec 18, 2024

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@DimitrisJim
Copy link
Contributor

is this an actual broken link? I seem to be able to access it? (ref https://ibc.cosmos.network/architecture/adr-008-app-caller-cbs/)
maybe .md is assumed suffix?

@duvbell
Copy link
Contributor Author

duvbell commented Dec 18, 2024

@DimitrisJim when i navigate around the code (vs-code), it seems does not work.

if it is not the intended behavior, i think we can close the PR

thanks for reviewing anw

@damiannolan
Copy link
Member

Within the context of the github repository I think the link is probably fine and works correctly. I think if you're navigating using your local dev env then it may attempt to take you to the root of your filesystem and then it is sad.

We can change if you want ¯_(ツ)_/¯ I don't feel strongly

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think as a general rule of thumb its better to use relative links in docs than absolute 👍🏻

@gjermundgaraba
Copy link
Contributor

Since the links work, I'll close this for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants